Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve segfault when running embeddedR test #869

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
3 participants
@filipsch
Copy link
Contributor

filipsch commented Jun 13, 2018

As @lionel- suggested, having the new environments be a child of the base environment fixed the nasty side effects described by @eddelbuettel and @coatless in #851 (comment).

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #869 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #869      +/-   ##
=========================================
+ Coverage   90.21%   90.3%   +0.09%     
=========================================
  Files          70      70              
  Lines        3261    3261              
=========================================
+ Hits         2942    2945       +3     
+ Misses        319     316       -3
Impacted Files Coverage Δ
R/Attributes.R 90.66% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5cdb8...640b419. Read the comment docs.

@eddelbuettel eddelbuettel merged commit a6ae672 into RcppCore:master Jun 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 15, 2018

Worked like a charm in reverse depends, and now part of Rcpp 0.12.17.3 -- so thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.