Resolve segfault when running embeddedR test #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
=========================================
+ Coverage 90.21% 90.3% +0.09%
=========================================
Files 70 70
Lines 3261 3261
=========================================
+ Hits 2942 2945 +3
+ Misses 319 316 -3
Continue to review full report at Codecov.
|
|
Worked like a charm in reverse depends, and now part of Rcpp 0.12.17.3 -- so thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @lionel- suggested, having the new environments be a child of the base environment fixed the nasty side effects described by @eddelbuettel and @coatless in #851 (comment).