Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX doesn't have tm_gmtoff #876

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@ayappanec
Copy link
Contributor

ayappanec commented Jul 9, 2018

AIX doesn't have tm_gmtoff due to which the compilation is failing. This PR will fix this issue.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          71       71           
  Lines        3271     3271           
=======================================
  Hits         2947     2947           
  Misses        324      324
Impacted Files Coverage Δ
src/Date.cpp 69.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c5a34...efcd91e. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jul 9, 2018

Hm, we have not had any AIX reports in some time. I wonder why that did not come up before. I see two other files with five total uses for #ifdef _AIX so this will probably not cause harm -- but still strange we did not need it before.

@ayappanec

This comment has been minimized.

Copy link
Contributor Author

ayappanec commented Jul 9, 2018

Not sure. I am just trying R in AIX and i found this issue.

@eddelbuettel eddelbuettel merged commit e5591c5 into RcppCore:master Jul 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.