* Changes to fix Subsetter's use of 'int' for indexing #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks promising at a first glance. I will toss it at a reverse depends check once my hands are from the RcppArmadillo release I am working on right now. I am sure @kevinushey and @thirdwing will give it a good read too. |
thirdwing
reviewed
Nov 10, 2018
|
Passed a full reverse depends check without issues, and nobody had anything else to object to (besides to the somewhat cosmetic issue raised by KK) so I think I'll merge this. |
|
I added the nicer message suggested by @thirdwing in 4f168e6. |
|
Thanks, looks like you got to it before I could :-).
Cheers,
Will
…On Mon, Nov 12, 2018 at 12:30 AM Dirk Eddelbuettel ***@***.***> wrote:
I added the nicer message suggested by @thirdwing
<https://github.com/thirdwing> in 4f168e6
<4f168e6>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#920 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Aqx9QVvCCbW03Ou-qQg3lj030w5wnZidks5uuEKsgaJpZM4YV-VW>
.
|
|
Sorry! Was out of town and intentionally staying away from computers so didn't see this until now. Post-hoc review is just a plain LGTM :-) Thanks for taking the time to file a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, this commit makes Subsetter use R_xlen_t for indexing/sizes. It also fixes a latent bug in indexing via Numeric's (the previous code created a temp IntegerVector of indices to use). Lastly, an exception is thrown in check_indices with a helpful warning message when attempting to index beyond 2^31 elements with an integral typed vector. All of these issues were basically only triggered in the case of indexing Vectors/Matrices with > 2^31 elements.