* Changes to fix Subsetter's use of 'int' for indexing #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, this commit makes Subsetter use R_xlen_t for indexing/sizes. It also fixes a latent bug in indexing via Numeric's (the previous code created a temp IntegerVector of indices to use). Lastly, an exception is thrown in check_indices with a helpful warning message when attempting to index beyond 2^31 elements with an integral typed vector. All of these issues were basically only triggered in the case of indexing Vectors/Matrices with > 2^31 elements.