Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
* Changes to fix Subsetter's use of 'int' for indexing #920
As discussed on the mailing list, this commit makes Subsetter use R_xlen_t for indexing/sizes. It also fixes a latent bug in indexing via Numeric's (the previous code created a temp IntegerVector of indices to use). Lastly, an exception is thrown in check_indices with a helpful warning message when attempting to index beyond 2^31 elements with an integral typed vector. All of these issues were basically only triggered in the case of indexing Vectors/Matrices with > 2^31 elements.
Nov 11, 2018
1 check passed
referenced this pull request
Nov 11, 2018
Thanks, looks like you got to it before I could :-). Cheers, Will…
On Mon, Nov 12, 2018 at 12:30 AM Dirk Eddelbuettel ***@***.***> wrote: I added the nicer message suggested by @thirdwing <https://github.com/thirdwing> in 4f168e6 <4f168e6> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#920 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aqx9QVvCCbW03Ou-qQg3lj030w5wnZidks5uuEKsgaJpZM4YV-VW> .