update sample.h for sort and sort_index interface change #111

Closed
eddelbuettel opened this Issue Oct 25, 2016 · 14 comments

Projects

None yet

2 participants

@eddelbuettel
Member

No description provided.

@coatless
Contributor

I have this

@eddelbuettel
Member

Too late, bud.

@coatless
Contributor

Blah.

@eddelbuettel
Member

Sorry 'bout that but as they tell you in primary school, don't work in isolation in the dark -- file an issue!

In all seriousness I think I added Contributing.md files in one or two repos strongly suggesting issue tickets before pull requests.

@coatless
Contributor

Normally claiming on SO was sufficient before:

http://stackoverflow.com/a/40241213/1345455

@eddelbuettel
Member
eddelbuettel commented Oct 25, 2016 edited

Agreed -- that was a case of bad timing. It fell into the gap of "getting up at home to get to work" and "sitting down at work". In the meantime, I fixed it on the laptop.

@coatless
Contributor

Oh well, moving on to other things. I'll stash the changes. FYI, RcppExports.R and RcppExports.cpp need to be updated.

@eddelbuettel
Member

That too is in my commit.

@coatless
Contributor

And if you could, please a & to the arma::vec &prob_

        T sample(const T &x, const int size, const bool replace, arma::vec &prob_)
@eddelbuettel
Member

If only you and I had something like a slack channel ... ๐Ÿ˜€

Again, too bad about the wasted energy but c'est la vie

@eddelbuettel
Member

Line 59, correct?

@coatless
Contributor

My editor has it on line 62:

This is the function:

        template <class T> 
        T sample(const T &x, const int size, const bool replace, arma::vec &prob_){
          return sample_main(x, size, replace, prob_);
        }
@eddelbuettel
Member
eddelbuettel commented Oct 25, 2016 edited

Yes, sorry, me too. Magit 'diff unstaged' shows the diff output and 59 is the first line of the diff segment. My operator error. Your error was throwing a random line out. GH is good at links with lines ...

I guess the only real fail here is that you should have opened an upstream ticket (here) when you filed the client ticket you filed for gmwm ๐Ÿ˜ž

@coatless
Contributor

@eddelbuettel: Cost of a speedy response to raise flag / highlight a change and ensure it made it into the commit.

And, aye, not filing a ticket here was an oversight on my part since the code base has a local copy of the sampling class vs. calling it within the RcppArmadillo namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment