Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning message for matrices that cannot be converted #147

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Add a warning message for matrices that cannot be converted #147

merged 1 commit into from
Jul 12, 2017

Conversation

binxiangni
Copy link
Contributor

Although just adding the warning message can pass the tests, it will not stop the program and provide a wrong result. Should I replace Rcpp::warning() with Rcpp::stop()?

@eddelbuettel
Copy link
Member

Yes, I was thinking that too when I wrote the message over there.

@thirdwing What do you think? stop() or warn() ?

@coatless
Copy link
Contributor

Should be Rcpp::stop().

Prior precedent:

@eddelbuettel eddelbuettel merged commit a0b57c5 into RcppCore:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants