Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning message for matrices that cannot be converted #147

Merged
merged 1 commit into from Jul 12, 2017

Conversation

@binxiangni
Copy link
Contributor

@binxiangni binxiangni commented Jul 12, 2017

Although just adding the warning message can pass the tests, it will not stop the program and provide a wrong result. Should I replace Rcpp::warning() with Rcpp::stop()?

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jul 12, 2017

Yes, I was thinking that too when I wrote the message over there.

@thirdwing What do you think? stop() or warn() ?

@coatless
Copy link
Contributor

@coatless coatless commented Jul 12, 2017

Should be Rcpp::stop().

Prior precedent:

@binxiangni binxiangni force-pushed the binxiangni:master branch from 9af2088 to 7ae7d54 Jul 12, 2017
@eddelbuettel eddelbuettel merged commit a0b57c5 into RcppCore:master Jul 12, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.