Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadded optional RCPP_ARMADILLO_RETURN_COLVEC_AS_VECTOR and co. #151
Conversation
Signed-off-by: Serguei Sokol <sokol at insa-toulouse.fr>
|
First off, thanks for getting this started! Second, I edited your markdown. Level headers (one #) are 'too loud'; I made them level four. And I made your code snippets code snippets. See what I did there, and read up on Markdown and GitHub-flavoured Markdoiwn. It is worth it. Third, this must have new unit tests. Adding them is trivial. Just look at the subdirectory and the |
|
This looks fine but is too minimal and bare. We need unit tests. We probably need a commented-out but documenting setting in RcppArmadilloConfig.h. |
unit_test_setup() is modified to accept character vector as first argument;
|
That looks good. I'll add ChangeLog and NEWS entries. |
I don't know how to add unit tests with RUnit so tested by hand with code snipets like the following:
legacy colvec
colvec tested with COLVEC
colvec tested with ANYVEC
legacy rowvec
rowvec tested with ROWVEC
rowvec tested with ANYVEC
Signed-off-by: Serguei Sokol