New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rlapack unit test #211

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
2 participants
@kthohr
Contributor

kthohr commented Mar 28, 2018

Add a unit test for complex-valued matrix decompositions. These tests are designed to trigger Lapack routines that were added to Rlapack in R versions 3.1.0 and 3.3.0.

/issues/207

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Mar 28, 2018

That looks very well done indeed! Full reverse-depends with your change is already cooking, sort-of-nearly-done and has not thrown up new issues. So all good so far.

(And I'll adjust the changelog email as well.)

@eddelbuettel eddelbuettel merged commit 3741eab into RcppCore:feature/less_crippled_lapack Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Mar 28, 2018

FWIW: I'll cherry-picked your commit and my commit over into a new branch and I'll PR that new one into master -- that should give us a slightly nicer git history graph with fewer crossing branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment