Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Rlapack unit test #211
Merged
Conversation
|
That looks very well done indeed! Full reverse-depends with your change is already cooking, sort-of-nearly-done and has not thrown up new issues. So all good so far. (And I'll adjust the changelog email as well.) |
eddelbuettel
merged commit 3741eab
into
RcppCore:feature/less_crippled_lapack
1 check passed
1 check passed
|
FWIW: I'll cherry-picked your commit and my commit over into a new branch and I'll PR that new one into master -- that should give us a slightly nicer git history graph with fewer crossing branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add a unit test for complex-valued matrix decompositions. These tests are designed to trigger Lapack routines that were added to Rlapack in R versions 3.1.0 and 3.3.0.
/issues/207