New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config check for Rlapack #214

Merged
merged 2 commits into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@kthohr
Contributor

kthohr commented Mar 29, 2018

From /issues/213

All Rlapack distributions should now trigger crippled_lapack guard.

kthohr added some commits Mar 29, 2018

Update config check for Rlapack
* All Rlapack distributions now trigger crippled_lapack guard
@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Mar 29, 2018

Thanks for also shipping configure. And you're of course spot on -- I just had a few quality minutes in the car dropping family off at the airport and didn't even think of the changed logic with the banded matrix decomp now being the driving factor. This should help indeed.

@eddelbuettel eddelbuettel merged commit d636962 into RcppCore:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kthohr

This comment has been minimized.

Contributor

kthohr commented Mar 29, 2018

Yep. Might have to re-enable a newR switch if these routines are ever added to Rlapack... (not likely to happen soon, I would guess)

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Mar 29, 2018

Indeed. And there is the open thread on the r-devel list. Maybe once R 3.5.0 is out we can re-hash with Peter and see if there is a way to get the next batch in for R 3.6.0 next year...

@kthohr kthohr deleted the kthohr:Rlapack-ac-check branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment