New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #229 #231

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@solivella
Contributor

solivella commented May 31, 2018

Enable use of example_code = FALSE argument in RcppArmadillo.package.skeleton() when pkgKitten is installed.

@@ -37,13 +37,16 @@ RcppArmadillo.package.skeleton <- function(name="anRpackage", list=character(),
skelFunName <- ifelse(haveKitten, "kitten", "package.skeleton")
message("\nCalling ", skelFunName, " to create basic package.")

This comment has been minimized.

@eddelbuettel

eddelbuettel May 31, 2018

Member

Not sure we need these but that is minor.

This comment has been minimized.

@solivella

solivella May 31, 2018

Contributor

:) For sure. I'll delete them and amend.

## first let the traditional version (or the kitten alternate) do its business
call <- match.call()
call[[1]] <- skelFunUsed
if ("example_code" %in% names(call)){
call[["example_code"]] <- NULL # remove the example_code argument
}

This comment has been minimized.

@eddelbuettel

eddelbuettel May 31, 2018

Member

Isn't this the same as removing example_code from the arguments? Ie we have two cases:

  • not set, moves on
  • set, removes it

So now example_code is effectively remove. I don't have a problem with that (I never used it) but this would need a different deprecation process.

This comment has been minimized.

@solivella

solivella May 31, 2018

Contributor

It is removed from the the call object, but the original argument itself is used later on (line 107 of original file).

This comment has been minimized.

@eddelbuettel

eddelbuettel May 31, 2018

Member

Indeed -- good call!

@eddelbuettel eddelbuettel merged commit 08d71ae into RcppCore:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

eddelbuettel added a commit that referenced this pull request Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment