Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes #229 #231
Merged
Fixes #229 #231
Conversation
R/RcppArmadillo.package.skeleton.R
Outdated
| @@ -37,13 +37,16 @@ RcppArmadillo.package.skeleton <- function(name="anRpackage", list=character(), | |||
| skelFunName <- ifelse(haveKitten, "kitten", "package.skeleton") | |||
| message("\nCalling ", skelFunName, " to create basic package.") | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
eddelbuettel
May 31, 2018
Member
Not sure we need these but that is minor.
Not sure we need these but that is minor.
solivella
May 31, 2018
Author
Contributor
:) For sure. I'll delete them and amend.
:) For sure. I'll delete them and amend.
| ## first let the traditional version (or the kitten alternate) do its business | ||
| call <- match.call() | ||
| call[[1]] <- skelFunUsed | ||
| if ("example_code" %in% names(call)){ | ||
| call[["example_code"]] <- NULL # remove the example_code argument | ||
| } |
eddelbuettel
May 31, 2018
•
Member
Isn't this the same as removing example_code from the arguments? Ie we have two cases:
- not set, moves on
- set, removes it
So now example_code is effectively remove. I don't have a problem with that (I never used it) but this would need a different deprecation process.
Isn't this the same as removing example_code from the arguments? Ie we have two cases:
- not set, moves on
- set, removes it
So now example_code is effectively remove. I don't have a problem with that (I never used it) but this would need a different deprecation process.
solivella
May 31, 2018
Author
Contributor
It is removed from the the call object, but the original argument itself is used later on (line 107 of original file).
It is removed from the the call object, but the original argument itself is used later on (line 107 of original file).
eddelbuettel
May 31, 2018
Member
Indeed -- good call!
Indeed -- good call!
eddelbuettel
added a commit
that referenced
this pull request
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Enable use of
example_code = FALSEargument inRcppArmadillo.package.skeleton()whenpkgKittenis installed.