Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword, indent, remove temporaries, roll minor #295

Merged
merged 1 commit into from May 5, 2020

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented May 5, 2020

Nothing major here but we now

  • show the (large) indented block for better logic,
  • add --clean to R CMD SHLIB (catching just the .o file)
  • explicitly remove .cpp, so, .dylib (does that catch all cases?)
  • add ChangeLog and NEWS as usual

I wonder if we could ask autoconf for a temp. dir. Probably cleanest.

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented May 5, 2020

This LGTM and I think obviates the need for my other PR.

@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented May 5, 2020

This LGTM and I think obviates the need for my other PR.

I am still wondering if we should something else (other than believing TEMPDIR, which is e.g. empty on my box) as discussed on Slack. And/or make the filename more unique. To be seen...

Also, is there another possible extension besides .so and .dylib we need to worry about?

@eddelbuettel eddelbuettel merged commit 9b004e1 into master May 5, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/configure_ac_followup branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.