work in private build dir during configure #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build dir generalization is good. I'll try to make time (in a day or two) to resolve the conflict due to us working on the same file at the same time, and get the change in. |
eddelbuettel
force-pushed
the
bugfix/openmp-configure-cleanup
branch
from
97a0551
to
d4b4046
Compare
|
Rebased, but need to check again it's all the way it is supposed to be... |
|
@kevinushey Have a quick glance over morning coffee, this should now be "final" if we get real lucky. |
|
LGTM; thanks for tidying everything up! |
|
Thanks for getting the ball rolling with the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs
R CMD SHLIBin a private directory within the temporary directory (fromTMPDIRif set; otherwise just/tmp) and then removes that directory.