Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for conversion to arma::Cube types #64

Merged
merged 3 commits into from Dec 1, 2015

Conversation

@nathan-russell
Copy link
Contributor

@nathan-russell nathan-russell commented Nov 30, 2015

As discussed in #63 this extends Rcpp::as<> for use with Armadillo's templated Cube class.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 1, 2015

As expected, this passed well during the regression tests. It is a really fine PR, and on reflection I think you need the extra specialization as they are all for cases where R does not have the underlying type: float or unsigned. I also really like the explicit unit tests.

eddelbuettel added a commit that referenced this pull request Dec 1, 2015
Added support for conversion to arma::Cube types
@eddelbuettel eddelbuettel merged commit ba54c0e into RcppCore:master Dec 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.