Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing bug in SpMat exporter #91
Merged
Conversation
This was referenced May 4, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Solves issue #89 as well as issue #72. RcppArmadillo was compiled and checked with Valgrind and no memory leaks (or issues with
Conditional jump...) where detected (nor in the examples, vignettes or tests). Also includes two new tests used to explicitly detect the two issues mentioned when usingR CMD check --use-valgrind.