New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Frequency? #48

Closed
cdeterman opened this Issue Feb 1, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@cdeterman

cdeterman commented Feb 1, 2018

I was wondering how often the 'newest' Eigen headers are ported in to this package? As what usually happens, I am dealing with GPU related problems and I noticed one pull request on the eigen bitbucket website that addressed the problem (quite minor in this case). I saw that it was merged back in May 2017 but the change isn't reflected in RcppEigen. Was a new 'official' release not provided by the Eigen authors perhaps?

I don't mean to push, as again this issue is quite minor in this instance. I am only curious how/when you decide to update the headers herein from the Eigen source.

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Feb 1, 2018

Of late, this mostly relied on Yixuan really carefully preparing new releases and handing them to me more or less ready and on a silver platter. But he and I are busy so we let 3.3.4 slip.

The changes are small, generally, and go back to things @dmbates needed/added for lme4. If you start from backing out diffs from our 0.3.3.3.1 to their 3.3.3, you should be able to prepare a 0.3.3.4.0 for us :)

@yixuan

This comment has been minimized.

Contributor

yixuan commented Feb 1, 2018

Let me prepare an update this weekend.

@yixuan yixuan referenced this issue Feb 4, 2018

Merged

Eigen 3.3.4 #49

@yixuan

This comment has been minimized.

Contributor

yixuan commented Feb 4, 2018

@cdeterman The patch you mentioned actually has not been ported to the 3.3 branch of Eigen. It was in the "default" branch, but I have manually patched it for you in #49 .

@cdeterman

This comment has been minimized.

cdeterman commented Feb 6, 2018

@yixuan excellent, thank you for your efforts.

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Feb 6, 2018

And it is sitting in incoming at CRAN now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment