Skip to content

Don't include R_ext/Lapack.h if MKL is used #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Nov 1, 2015

If Eigen is configured to use MKL, the inclusion of R_ext/Lapack.h results in incompatible declaration errors (R 3.2.0, GCC 5.1.0, MKL 11.0).

@eddelbuettel
Copy link
Member

Do you define EIGEN_USE_MKL or do you set another flag to Eigen?

@alyst
Copy link
Contributor Author

alyst commented Nov 1, 2015

I add -DEIGEN_USE_MKL_ALL to CXXFLAGS in my Makevars as suggested here.

@eddelbuettel
Copy link
Member

Note that the page you reference to, as well as your comment, suggest

EIGEN_USE_MKL_ALL

whereas your pull request has

EIGEN_USE_MKL

Do we need to amend to the PR?

@alyst
Copy link
Contributor Author

alyst commented Nov 2, 2015

@eddelbuettel No, I suppose we shouldn't change it for that reason. See MKL_support.h: <mkl.h> is included iff EIGEN_USE_MKL is defined, and it's defined if any of the MKL-related user options (including EIGEN_USE_MKL_ALL) are turned on.

@eddelbuettel
Copy link
Member

I see -- in that case I'll merge ahead.

eddelbuettel added a commit that referenced this pull request Nov 2, 2015
Don't include R_ext/Lapack.h if MKL is used
@eddelbuettel eddelbuettel merged commit 181af62 into RcppCore:master Nov 2, 2015
eddelbuettel added a commit that referenced this pull request Nov 2, 2015
@alyst
Copy link
Contributor Author

alyst commented Nov 2, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants