Another UBSAN patch for Eigen 3.2.8 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
added a commit
that referenced
this pull request
Feb 28, 2016
Another UBSAN patch for Eigen 3.2.8
|
I just run a big loop, installing to subdirectory below /tmp -- see the simple script here. Will turn that on in a moment. Big thanks, as always, for "taking care of business". |
|
Sorry, got distracted yesterday. Reverse-Depends check passed just fine, I will wrap this up later this evening and send it out. Is it your understanding that this change is now in upstream as well, or do we need a reminder to re-apply it next time? |
|
Thanks for the careful check! It will appear in the next release. |
|
Great. One less thing for us to worry about :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eddelbuettel ,
I had this patch from Eigen: http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1172.
However I was unable to check it on
RcppEigenand dependent packages, since it seems that I need to recompile everything in my local machine. Do you have any environment to test it?