Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Exporter and Unit Test for Map::RowVectorX<t> #32

Merged
merged 4 commits into from Apr 29, 2016

Conversation

@coatless coatless changed the title Added Exporters and Unit Test for RowVectorXd Added Exporters and Unit Test for RowVectorX<t> Apr 28, 2016
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Apr 28, 2016

Thanks, James -- that is very helpful (and very fast). Paging @yixuan to take a peek too but I guess we should be able to fold this in.

@coatless coatless changed the title Added Exporters and Unit Test for RowVectorX<t> Added Exporter and Unit Test for Map::RowVectorX<t> Apr 28, 2016
@yixuan
Copy link
Contributor

@yixuan yixuan commented Apr 29, 2016

It looks pretty nice, thank you @coatless !

Could you please also convert tab to 4 spaces in RcppEigenWrap.h and make the indentation consistent with the context in runit.RcppEigen.R? (It is tiny issue but would be nice of you to do so.)

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Apr 29, 2016

Good point tabs (I tend to avoid them) and four spaces. The Rcpp repo has some emacs config, it needed.

coatless added 2 commits Apr 29, 2016
@coatless
Copy link
Contributor Author

@coatless coatless commented Apr 29, 2016

@yixuan done.

}
OUT get() {return OUT(vec.begin(), vec.size());}
} ;

This comment has been minimized.

@eddelbuettel

eddelbuettel Apr 29, 2016
Member

That whole block is two-space-intended (after the initial four) but c'est la vie now, we'll get it next time or maybe I'll fix it tomorrow.

@eddelbuettel eddelbuettel merged commit 3948d5c into RcppCore:master Apr 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eddelbuettel added a commit that referenced this pull request Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.