Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to Eigen 3.2.9 #37
Merged
Conversation
|
That was fast :) I'll build it tomorrow morning, and run some rev.deps as well. Thanks so much! |
|
I can think of two non-standard things we had in 3.2.8, and you carried them both over
Great work |
|
Oh, and extra brownie points for updating README.md etc -- the little R-devel CMD check things :) |
|
Clean rev.deps here, only BayesFactor gives me trouble, and it did that before too. (I may have a dependency compiled with a different setup, not quite sure -- I do not worry about this.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR imports Eigen 3.2.9 to
RcppEigen.In the reverse dependence check, I find that the
Cyclopspackage does not compile, but the error is not related toRcppEigen. In fact it does not compile either withRcppEigen0.3.2.8.1 in my machine. I'm a bit surprised since it passes most of the CRAN checks (with two errors). I guess it's due to some new error triggers in GCC 6.