Update to Eigen 3.2.9 #37

Merged
merged 3 commits into from Aug 20, 2016

Projects

None yet

2 participants

@yixuan
Contributor
yixuan commented Aug 20, 2016

This PR imports Eigen 3.2.9 to RcppEigen.

In the reverse dependence check, I find that the Cyclops package does not compile, but the error is not related to RcppEigen. In fact it does not compile either with RcppEigen 0.3.2.8.1 in my machine. I'm a bit surprised since it passes most of the CRAN checks (with two errors). I guess it's due to some new error triggers in GCC 6.

@eddelbuettel
Member

That was fast :) I'll build it tomorrow morning, and run some rev.deps as well.

Thanks so much!

@eddelbuettel
Member

I can think of two non-standard things we had in 3.2.8, and you carried them both over

Great work

@eddelbuettel
Member

Oh, and extra brownie points for updating README.md etc -- the little R-devel CMD check things :)

@eddelbuettel eddelbuettel merged commit f8ba1ed into RcppCore:master Aug 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel
Member

Clean rev.deps here, only BayesFactor gives me trouble, and it did that before too. (I may have a dependency compiled with a different setup, not quite sure -- I do not worry about this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment