Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport long vectors #55
Merged
Conversation
There is one remaining use of Rf_length where the dimensions are checked. Long vectors support is not needed there.
The individual indices for matrices in R are of type int, but the size is potentially larger than that. R_xlen_t is used for the product of the number of ros and columns.
|
Looks good at a first glance! |
|
No regression in a reverse depends check, so merging. Thanks for the PR. |
eddelbuettel
added a commit
that referenced
this pull request
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I have not tried to convert the two test cases from the issue into unit tests due to memory considerations.
(fixes #54)