Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fread stringsAsFactors=0.2 #2025

Closed
mattdowle opened this issue Feb 15, 2017 · 2 comments · Fixed by #2545
Closed

fread stringsAsFactors=0.2 #2025

mattdowle opened this issue Feb 15, 2017 · 2 comments · Fixed by #2545

Comments

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Feb 15, 2017

For character columns, if uniqueN(column)/nrow < 0.2 then make the column a factor. Generalizing current binary argument to a scale between FALSE (0.0) and TRUE (1.0).
Request came up for onwards model build which switches based on character / factor type.
No change to default FALSE.

@mattdowle mattdowle added this to the v1.10.6 milestone Feb 15, 2017
@mattdowle mattdowle removed this from the v1.10.6 milestone Nov 10, 2017
@mattdowle mattdowle added this to the Candidate milestone Nov 10, 2017
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018
@mattdowle mattdowle added this to the 1.12.4 milestone May 1, 2019
@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Sep 15, 2020

the closing PR is a bit large, @HughParsonage can you confirm this issue was closed at the R level? I seem to recall it was...

@HughParsonage
Copy link
Member

@HughParsonage HughParsonage commented Sep 15, 2020

Yes:

if (is.double(stringsAsFactors)) { #2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants