Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frank #2328

Closed
cguill95 opened this issue Sep 4, 2017 · 1 comment · Fixed by #3574
Closed

frank #2328

cguill95 opened this issue Sep 4, 2017 · 1 comment · Fixed by #3574
Milestone

Comments

@cguill95
Copy link

@cguill95 cguill95 commented Sep 4, 2017

Hi,

Maybe this is not a real issue and the wanted behavior but I just wanted to draw your attention to the inconsistent behavior between the rank function and the frank function in the way they deal with capital letters.

`> frank(c("Da", "DA", "DB"))
[1] 3 1 2

rank(c("Da", "DA", "DB"))
[1] 1 2 3`

@franknarf1
Copy link
Contributor

@franknarf1 franknarf1 commented Sep 5, 2017

It's probably related to this in ?setorder

data.table always reorders in C-locale. To sort by session locale, use x[base::order(.)] instead.

However, I don't see a similar note in ?frank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants