Skip to content

/ data.table

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed NAMED to MAYBE_SHARED #2330

Closed
mattdowle opened this issue Sep 5, 2017 · 0 comments
Closed

Changed NAMED to MAYBE_SHARED #2330

mattdowle opened this issue Sep 5, 2017 · 0 comments
Milestone
v1.11.0

Comments

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 5, 2017

Request from R-core to update data.table to work with the new API for NAMED.
In assign.c (at least) :
"if (NAMED(x) == 2)" => "if (MAYBE_SHARED(x))"
http://r.789695.n4.nabble.com/Please-avoid-direct-use-of-NAMED-and-SET-NAMED-macros-td4745169.html
https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Named-objects-and-copying
@mattdowle mattdowle added this to the v1.10.6 milestone Sep 5, 2017
@mattdowle mattdowle mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.11.0
Linked pull requests

Successfully merging a pull request may close this issue.

Backport for CRAN patch (1.10.4-1)
1 participant
@mattdowle
You can’t perform that action at this time.