Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as.IDate.numeric should still interpret as days? #2446

Closed
MichaelChirico opened this issue Oct 26, 2017 · 0 comments
Closed

as.IDate.numeric should still interpret as days? #2446

MichaelChirico opened this issue Oct 26, 2017 · 0 comments
Labels
bug dev idate/itime
Milestone
v1.11.0

Comments

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Oct 26, 2017 •
edited

Just found a major bug in some code introduced by the new-ish as.IDate.numeric method.

It seems numeric are automatically interpreted as seconds instead of days. Shouldn't that be as.ITime.numeric's interpretation?

In particular I got bit by the assumption that as.IDate and as.Date are interchangeable, but this violates that.

If we're going to interpret numeric input as seconds (I don't think it should), this must be added to the documentation.

@jangorecki I believe this was part of your PR #1393, was this intentional?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dev idate/itime
Projects
None yet
Milestone
v1.11.0
Development

No branches or pull requests
2 participants
@mattdowle @MichaelChirico