R-devel change; R-API inside parallel regions #3165
Luke Tierney contacted me about a memory issue in R-devel. Tests are passing both on CRAN and Travis/Appveyor, but memory usage is higher in some cases. As before the garbage collector turns off.
Luke wrote :
Given Luke's detail, it's easy to see the problem in the code without needing to reproduce. All R API usage needs taking outside all parallel regions as Luke requested before. I delayed doing that last time due to time pressure, and now it needs tackling. Last time I just did the first step which was to ensure that DATAPTR inside parallel regions did not receive ALTREP.
This warrants accelerating release of 1.12.0, not least because it impacts Luke.
The text was updated successfully, but these errors were encountered:
Confirmed fixed. Thanks to @ltierney for his help.
For completeness in case we need to refer back...
even with the script that Luke provided :
As a long shot, I recompiled R-devel more simply as follows, still with
Installing data.table-dev (1.11.9) into this R-devel and rerunning, works fine. Reinstalling data.table 1.11.8 again fails. So it's indeed fixed by 1.11.9. In my original R-devel compile, perhaps something there was making 1.11.8 work (disabling byte compiler, -00, ASAN, etc). Anyway, a simpler R-devel compile was needed and was worth trying.
@jangorecki If time allows, it would be great to add