Skip to content

/ data.table

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grouping sets incorrectly handle constant value in `j` #3173

Closed
jangorecki opened this issue Dec 1, 2018 · 0 comments
Closed

grouping sets incorrectly handle constant value in `j` #3173

jangorecki opened this issue Dec 1, 2018 · 0 comments
Assignees
@jangorecki
Milestone
1.12.0

Comments

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Dec 1, 2018

spotted by @MichaelChirico in #3168 (comment)
@jangorecki jangorecki added this to the 1.12.0 milestone Dec 1, 2018
@jangorecki jangorecki self-assigned this Dec 1, 2018
@MichaelChirico MichaelChirico mentioned this issue Dec 1, 2018
Merged
jangorecki added a commit that referenced this issue Dec 1, 2018
@jangorecki
groupingsets edge case for const j fix, closes #3173
Verified
This commit was signed with a verified signature.
jangorecki Jan Gorecki
GPG key ID: D1FA192FD139A5BD Learn about signing commits
Loading status checks…
ed8194c
@jangorecki jangorecki mentioned this issue Dec 1, 2018
Merged
MichaelChirico pushed a commit that referenced this issue Dec 1, 2018
Michael Chirico
Drop test of bug given #3173, #3174
Loading status checks…
491b201
@MichaelChirico MichaelChirico mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangorecki jangorecki

Labels
None yet
Projects
None yet
Milestone
1.12.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jangorecki
You can’t perform that action at this time.