Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The foverlaps() function seems produce an incorrect answer (data.table 1.12.0) #3349

Closed
lux5 opened this issue Feb 4, 2019 · 3 comments · Fixed by #3382
Closed

The foverlaps() function seems produce an incorrect answer (data.table 1.12.0) #3349

lux5 opened this issue Feb 4, 2019 · 3 comments · Fixed by #3382
Assignees
Labels
Milestone

Comments

@lux5
Copy link

@lux5 lux5 commented Feb 4, 2019

Hi,

The foverlaps() function seems produce an incorrect answer - the detailed description of the issue and sample codes/data were posted by me in here.

Could anyone have a look and give a try on the posted sample codes? Many thanks!

BTW, I am using data.table 1.12.0 running on R version 3.5.2 (2018-12-20).

@arunsrinivasan
Copy link
Member

@arunsrinivasan arunsrinivasan commented Feb 9, 2019

I can't access the dropbox link you provided in your SO post. Are you sure it's functional?

@arunsrinivasan arunsrinivasan self-assigned this Feb 9, 2019
@arunsrinivasan
Copy link
Member

@arunsrinivasan arunsrinivasan commented Feb 9, 2019

Nevermind, the link works fine. Found the issue and just patched. Will test and push.

@lux5
Copy link
Author

@lux5 lux5 commented Feb 10, 2019

Thank you for the fix arunsrinivasan.

data.table always makes my work a lot of easier.
I am looking forward to the updated version ;)

@mattdowle mattdowle added this to the 1.12.2 milestone Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants