Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename alloc.col to set.alloc.col #3475

Closed
jangorecki opened this issue Mar 27, 2019 · 2 comments · Fixed by #3792
Closed

rename alloc.col to set.alloc.col #3475

jangorecki opened this issue Mar 27, 2019 · 2 comments · Fixed by #3792
Assignees
Milestone

Comments

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Mar 27, 2019

for consistency

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Mar 28, 2019

If we're going to change, I wouldn't use set.alloc.col which sounds odd.

set_allocated_columns or the like would be more expressive & help get at what it's doing

@shrektan
Copy link
Member

@shrektan shrektan commented Mar 28, 2019

A little off-topic, but I really wish one day there's a way to auto set alloc.col() to the data.table objects from RDS files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants