Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift(nanotime, fill=NA) does not fill nanotime NA #3945

Closed
mschubmehl opened this issue Oct 6, 2019 · 0 comments · Fixed by #3942
Closed

shift(nanotime, fill=NA) does not fill nanotime NA #3945

mschubmehl opened this issue Oct 6, 2019 · 0 comments · Fixed by #3942

Comments

@mschubmehl
Copy link
Contributor

@mschubmehl mschubmehl commented Oct 6, 2019

Calling shift on a nanotime does not identify the nanotime as inheriting from bit64::integer64, and thus fills the numeric NA instead of the integer64:

data.table::shift(nanotime::nanotime(1:4))

[1] "2262-02-18T20:47:17.227407266+00:00" "1970-01-01T00:00:00.000000001+00:00"
[3] "1970-01-01T00:00:00.000000002+00:00" "1970-01-01T00:00:00.000000003+00:00"

Fixed by #3942:

[1] NA                                    "1970-01-01T00:00:00.000000001+00:00"
[3] "1970-01-01T00:00:00.000000002+00:00" "1970-01-01T00:00:00.000000003+00:00"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix NA filled by shift(nanotime, fill=NA) Rdatatable/data.table
1 participant
@mschubmehl