New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-Forge #5758] unique and duplicated should also warn on columns with mixed encodings. #469

Open
arunsrinivasan opened this Issue Jun 8, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@arunsrinivasan
Member

arunsrinivasan commented Jun 8, 2014

Submitted by: Arun ; Assigned to: Nobody; R-Forge link

Sigh! It just seems not possible to put this (mixed) encoding issue to rest. As reported here on SO.

@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014

@arunsrinivasan arunsrinivasan added the High label Jun 26, 2014

@arunsrinivasan arunsrinivasan modified the milestones: 2.0.1, v2.0 Sep 6, 2014

@arunsrinivasan arunsrinivasan modified the milestones: v1.9.6, v1.9.8 Oct 10, 2014

arunsrinivasan added a commit that referenced this issue Jan 20, 2016

@arunsrinivasan arunsrinivasan self-assigned this Jan 20, 2016

arunsrinivasan added a commit that referenced this issue Jan 27, 2016

Better fix for encoding issues, #66, #69, #469, #1293.
When marked non-utf8 encodings are detected, they are internally converted to utf-8 before comparing.
@mattdowle

This comment has been minimized.

Show comment
Hide comment
@mattdowle

mattdowle Nov 23, 2016

Member

Unfortunately this added encoding into tests.Rraw which fails the tests in CRAN_Release.cmd because it fails on CRAN when it gets to Mac if I remember correctly, which is why I put the grep into CRAN_Release.cmd. I'll have to take the test out.

Member

mattdowle commented Nov 23, 2016

Unfortunately this added encoding into tests.Rraw which fails the tests in CRAN_Release.cmd because it fails on CRAN when it gets to Mac if I remember correctly, which is why I put the grep into CRAN_Release.cmd. I'll have to take the test out.

@mattdowle mattdowle reopened this Nov 23, 2016

mattdowle added a commit that referenced this issue Nov 23, 2016

Encoding characters removed from tests.Rraw. They fail the grep in CR…
…AN_Release.cmd because they've failed on CRAN before. Reopened issue #469 and postponed it to v1.9.10 to resinstate these tests into DtNonAsciiTests package. Those characters cannot even be commented out because their presence in the file causes the CRAN issue. There probably is a better solution but I do not know it.

@mattdowle mattdowle modified the milestones: v1.9.10, v1.9.8 Nov 23, 2016

@jangorecki

This comment has been minimized.

Show comment
Hide comment
@jangorecki

jangorecki Nov 23, 2016

Member

afaiu those tests could goes under #1343?

Member

jangorecki commented Nov 23, 2016

afaiu those tests could goes under #1343?

@arunsrinivasan

This comment has been minimized.

Show comment
Hide comment
@arunsrinivasan

arunsrinivasan Jan 23, 2018

Member

@mattdowle okay. What's the way to add tests for encoding related issues then? The issue seems fixed, just trying to wrap up the test so it can be closed.

Member

arunsrinivasan commented Jan 23, 2018

@mattdowle okay. What's the way to add tests for encoding related issues then? The issue seems fixed, just trying to wrap up the test so it can be closed.

@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment