[R-Forge #5445] numeric rounding should be 0 or 1 automatically for POSIXct #485

Open
arunsrinivasan opened this Issue Jun 8, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@arunsrinivasan
Member

arunsrinivasan commented Jun 8, 2014

Submitted by: Matt Dowle; Assigned to: Nobody; R-Forge link

As highlighted here on SO.

Users shouldn't need to know or call setNumericRounding for this.

@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014

@arunsrinivasan arunsrinivasan added the High label Jun 21, 2014

@arunsrinivasan arunsrinivasan removed this from the v1.9.4 milestone Jun 26, 2014

@arunsrinivasan arunsrinivasan added this to the v2.0.0 milestone Dec 2, 2015

@mattdowle

This comment has been minimized.

Show comment
Hide comment
@mattdowle

mattdowle Jan 28, 2016

Member

Note also ?setNumericRounding contains "[1 will] become the default for POSIXct types in the future, instead of the default 2." to update when done.
Further, if you have 2 column join/group, both numeric, one POSIXct and the other say stock prices (fixed decimal precision), then you'd want it to use the appropriate rounding for the column. But we can only control one global rounding level currently.

Member

mattdowle commented Jan 28, 2016

Note also ?setNumericRounding contains "[1 will] become the default for POSIXct types in the future, instead of the default 2." to update when done.
Further, if you have 2 column join/group, both numeric, one POSIXct and the other say stock prices (fixed decimal precision), then you'd want it to use the appropriate rounding for the column. But we can only control one global rounding level currently.

arunsrinivasan added a commit that referenced this issue Jul 21, 2016

Handles #1642, #1728, #1463, #485. Full precision grouping/ordering/j…
…oining by default, i.e., no rounding.
@arunsrinivasan

This comment has been minimized.

Show comment
Hide comment
@arunsrinivasan

arunsrinivasan Jul 21, 2016

Member

Default is not to do rounding for now..

Member

arunsrinivasan commented Jul 21, 2016

Default is not to do rounding for now..

arunsrinivasan added a commit that referenced this issue Jul 21, 2016

@mattdowle

This comment has been minimized.

Show comment
Hide comment
@mattdowle

mattdowle Nov 23, 2016

Member

Not fully sure but iiuc we now don't do rounding at all. Which was good move for now. Reopening to come back to this in 1.9.10 and do the appropriate rounding as intended.

Member

mattdowle commented Nov 23, 2016

Not fully sure but iiuc we now don't do rounding at all. Which was good move for now. Reopening to come back to this in 1.9.10 and do the appropriate rounding as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment