Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fread nextGoodLine fixed for \r only files #2352

Merged
merged 6 commits into from Sep 12, 2017
Merged

fread nextGoodLine fixed for \r only files #2352

merged 6 commits into from Sep 12, 2017

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 12, 2017

Closes #2351
I added a test to generate a 1e5 row file with \r line endings only, with and without a final \r after the last line. I checked it works now with chicagoAllWeather.csv.

@mattdowle mattdowle added this to the v1.10.6 milestone Sep 12, 2017
@mattdowle mattdowle requested a review from st-pasha Sep 12, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Sep 12, 2017

Codecov Report

Merging #2352 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2352      +/-   ##
==========================================
+ Coverage    91.1%   91.16%   +0.05%     
==========================================
  Files          61       61              
  Lines       11806    11813       +7     
==========================================
+ Hits        10756    10769      +13     
+ Misses       1050     1044       -6
Impacted Files Coverage Δ
src/fread.c 95.27% <100%> (+0.12%) ⬆️
src/rbindlist.c 88.93% <0%> (+0.19%) ⬆️
src/forder.c 94.47% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f8296...c6d3466. Read the comment docs.

@mattdowle mattdowle merged commit 5e5c451 into master Sep 12, 2017
6 checks passed
@mattdowle mattdowle deleted the issue_2351 branch Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants