fread nextGoodLine fixed for \r only files #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2352 +/- ##
==========================================
+ Coverage 91.1% 91.16% +0.05%
==========================================
Files 61 61
Lines 11806 11813 +7
==========================================
+ Hits 10756 10769 +13
+ Misses 1050 1044 -6
Continue to review full report at Codecov.
|
st-pasha
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #2351
I added a test to generate a 1e5 row file with \r line endings only, with and without a final \r after the last line. I checked it works now with chicagoAllWeather.csv.