Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improved key handling when assigning with ':=' #2389
This closes #2372.
Now, when updating columns with :=, existing keys and indices are retained up to the first modified column (exclusive).
The tests 1400 ff had to be modified since they were testing for the old behaviour.
I tested for C memory allocation problems with
A small benchmark (code at the end of this post) shows that there is no speed penalty associated with the new implementation:
@@ Coverage Diff @@ ## master #2389 +/- ## ========================================== + Coverage 91.24% 91.29% +0.04% ========================================== Files 62 62 Lines 11978 12023 +45 ========================================== + Hits 10929 10976 +47 + Misses 1049 1047 -2
Sorry - I guess I broke it by removing
I've added you as a project member so that you can create branches inside the main repo if you'd like. This will mean I can pull, test and push to your branch, rather than me using the online editor as I'm doing now.
Currently, we have to skip test numbers ending zero because, for example, if 1419.10 fails, it prints as 1419.1 the same as 1419.1 and we can't distinguish. Haven't thought of a solution yet. For now, I just think of it as a bit of culture/personality in the code, like missing unlucky number 13.