Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "broken" R 3.1.0 dependency introduced by failing test 1555.1 #2489

Merged
merged 1 commit into from Nov 21, 2017

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Nov 17, 2017

See discussion on #2484; with this minor change, test.data.table() runs successfully on R 3.1.0

@codecov-io
Copy link

@codecov-io codecov-io commented Nov 17, 2017

Codecov Report

Merging #2489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2489   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          63       63           
  Lines       12046    12046           
=======================================
  Hits        11032    11032           
  Misses       1014     1014

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc8b37...29dcde9. Read the comment docs.

@mattdowle mattdowle merged commit f80b5a6 into master Nov 21, 2017
5 checks passed
@mattdowle mattdowle deleted the fix_test_1555_1_r_version branch Nov 21, 2017
@mattdowle
Copy link
Member

@mattdowle mattdowle commented Nov 21, 2017

Great robust fix @MichaelChirico!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants