Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgetDTthreads more robust #2708
Merged
getDTthreads more robust #2708
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Mar 28, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #2708 +/- ##
==========================================
- Coverage 93.33% 93.32% -0.01%
==========================================
Files 61 61
Lines 12220 12225 +5
==========================================
+ Hits 11405 11409 +4
- Misses 815 816 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mattdowle commentedMar 28, 2018
•
edited
Attempt 1 for #2707
If user calls
setDTthread(0)
it was callingomp_set_num_threads()
toomp_get_thread_limit()
which wasINT_MAX
by default. Relatively newfsort
was usingDTthreads
without restriction, whereas usage elsewhere was typically limiting number of threads based on chunk size or similar.All usage of
omp_set.*
removed and thegrep
in CRAN_Release.cmd expanded to include openmp-utils.c, too.