Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print topn rows properly when class=TRUE (#2803) #2804

Merged
merged 3 commits into from Apr 28, 2018

Conversation

@heavywatal
Copy link
Contributor

heavywatal commented Apr 28, 2018

Closes #2803.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 28, 2018

Codecov Report

Merging #2804 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2804   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          61       61           
  Lines       12365    12365           
=======================================
  Hits        11560    11560           
  Misses        805      805
Impacted Files Coverage Δ
R/print.data.table.R 98.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53618b4...2dcf9b1. Read the comment docs.

@MichaelChirico

This comment has been minimized.

Copy link
Member

MichaelChirico commented Apr 28, 2018

Would you mind adding a test to be sure this behavior doesn't inadvertently revert in the future? There's some pointers on the Contributing page

@mattdowle mattdowle added this to the v1.11.0 milestone Apr 28, 2018
@mattdowle mattdowle merged commit cd3b808 into Rdatatable:master Apr 28, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 93.48%)
Details
codecov/project 93.48% (+0%) compared to 53618b4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
heavywatal added a commit to heavywatal/data.table that referenced this pull request Apr 29, 2018
Remove extra parentheses in my previous PR Rdatatable#2804
@heavywatal heavywatal deleted the heavywatal:print-class-true branch Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.