Test 1590 robust to locale #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 61 61
Lines 12367 12367
=======================================
Hits 11558 11558
Misses 809 809Continue to review full report at Codecov.
|
|
@jangorecki I'll merge without review given CRAN release is pressing. Please check post-merge and we can always revert if needed. |
| oy = if (length(oy <- forderv(y))) oy else seq_along(y) | ||
| test(1590.5, oy, order(y)) | ||
| # data.table::forderv is encoding-aware and independent of locale | ||
| # [ Aside: data.table needs to be independent of locale because keys/indexes depend on a sort order. If a data.table is stored on disk with a key |
There was a problem hiding this comment.
note to self to add this to FAQ #2664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2771