Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS NULL in prepareFastSubset #3031

Merged
merged 2 commits into from Sep 5, 2018
Merged

RHS NULL in prepareFastSubset #3031

merged 2 commits into from Sep 5, 2018

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 5, 2018

In rev dep checking I found that data.table broke CRAN package eplusr. Not bad really to have just one breakage in an edge case.
The one-line addition in this PR makes it pass.
Please check ok @MarkusBonsch and is there a way to create a test for this?
Since mode(NULL)=="NULL" it might be to do with the mode()!=mode() that Hugh and I recently removed in PR #3026.

@mattdowle mattdowle added this to the 1.11.6 milestone Sep 5, 2018
@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #3031 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3031   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          61       61           
  Lines       11736    11736           
=======================================
  Hits        10663    10663           
  Misses       1073     1073
Impacted Files Coverage Δ
R/data.table.R 91.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45a173...1367b20. Read the comment docs.

…ase. Achieves the simplification desired by original TODO comment on this block.
@mattdowle mattdowle merged commit cc517c5 into master Sep 5, 2018
@mattdowle mattdowle deleted the prepare-subset-RHS-null branch September 5, 2018 19:54
@MarkusBonsch
Copy link
Contributor

MarkusBonsch commented Sep 5, 2018

Thanks, @mattdowle for fixing my bugs :) It is strange, however, that this bug is new, since the piece of code that you changed was just copy-pasted by me when implementing .prepareFastSubset. So maybe your guess is right and it has to do with PR #3026.

Since I am not fully aware of the problem, I can not check, whether there can be a test for this. Can you provide an example?

@mattdowle
Copy link
Member Author

Thanks @MarkusBonsch. The NULL example came from eplusr package. It was a bit tortuous to debug it as the NULL occurred on the 18th iteration of a loop and I wasn't able to establish the root cause. I think the way it is now with this PR is better, especially as it's more like your original. Passes CRAN packages. Would be ideal to add a test but bigger problems to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants