Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsetequal handle last col a character #3219

Merged
merged 1 commit into from Dec 14, 2018
Merged

fsetequal handle last col a character #3219

merged 1 commit into from Dec 14, 2018

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Dec 14, 2018 •
edited by mattdowle

Closes #2318

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #3219 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   94.59%   94.59%   +<.01%     
==========================================
  Files          61       61              
  Lines       11736    11740       +4     
==========================================
+ Hits        11102    11106       +4     
  Misses        634      634
Impacted Files Coverage Δ
R/setops.R 98.95% <100%> (+0.03%) ⬆️
src/gsumm.c 90.88% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550b8a7...8d2867a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 14, 2018 •
edited

Codecov Report

Merging #3219 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   94.59%   94.59%   +<.01%     
==========================================
  Files          61       61              
  Lines       11736    11740       +4     
==========================================
+ Hits        11102    11106       +4     
  Misses        634      634
Impacted Files Coverage Δ
R/setops.R 98.95% <100%> (+0.03%) ⬆️
src/gsumm.c 90.88% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550b8a7...8d2867a. Read the comment docs.

@mattdowle mattdowle changed the title fsetequal handle last col a character, closes #2318 fsetequal handle last col a character Dec 14, 2018
@mattdowle mattdowle added this to the 1.12.0 milestone Dec 14, 2018
@mattdowle mattdowle merged commit af601da into master Dec 14, 2018
@mattdowle mattdowle deleted the fsetequal-char-col branch December 14, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jangorecki @mattdowle