Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval on quoted expression of := will handle dot alias #3425

Merged
merged 4 commits into from Feb 27, 2019

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 21, 2019

@codecov
Copy link

@codecov codecov bot commented Feb 21, 2019

Codecov Report

Merging #3425 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
+ Coverage   95.05%   95.06%   +<.01%     
==========================================
  Files          65       65              
  Lines       12246    12249       +3     
==========================================
+ Hits        11641    11644       +3     
  Misses        605      605
Impacted Files Coverage Δ
R/data.table.R 97.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49ea2f...a4110d1. Read the comment docs.

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Feb 21, 2019

Looks good. Just needs a news item please.

@jangorecki
Copy link
Member Author

@jangorecki jangorecki commented Feb 23, 2019

@mattdowle done

@mattdowle mattdowle added this to the 1.12.2 milestone Feb 27, 2019
@mattdowle mattdowle merged commit 8bfd168 into master Feb 27, 2019
4 checks passed
@mattdowle mattdowle deleted the eval-map-dot-to-list branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants