Skip to content

/ data.table

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval on quoted expression of := will handle dot alias #3425

Merged
merged 4 commits into from Feb 27, 2019
Merged

eval on quoted expression of := will handle dot alias #3425

merged 4 commits into from Feb 27, 2019

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 21, 2019 •
edited

solves https://stackoverflow.com/questions/41228076/using-data-tables-shortcut-in-quoted-expressions
@franknarf1
@jangorecki
eval on quoted expression of := will handle dot alias
Verified
This commit was signed with a verified signature.
jangorecki Jan Gorecki
GPG key ID: D1FA192FD139A5BD Learn about signing commits
Loading status checks…
c6b90ca
@codecov
Copy link

@codecov codecov bot commented Feb 21, 2019 •
edited

Codecov Report

Merging #3425 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
+ Coverage   95.05%   95.06%   +<.01%     
==========================================
  Files          65       65              
  Lines       12246    12249       +3     
==========================================
+ Hits        11641    11644       +3     
  Misses        605      605
Impacted Files Coverage Δ
R/data.table.R 97.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49ea2f...a4110d1. Read the comment docs.
@mattdowle
Copy link
Member

@mattdowle mattdowle commented Feb 21, 2019

Looks good. Just needs a news item please.
mattdowle and others added 2 commits Feb 23, 2019
@mattdowle
Merge branch 'master' into eval-map-dot-to-list
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d6ef49c
@jangorecki
news entry
Verified
This commit was signed with a verified signature.
jangorecki Jan Gorecki
GPG key ID: D1FA192FD139A5BD Learn about signing commits
Loading status checks…
5729a26
@jangorecki
Copy link
Member Author

@jangorecki jangorecki commented Feb 23, 2019

@mattdowle done
@mattdowle mattdowle added this to the 1.12.2 milestone Feb 27, 2019
@mattdowle
Merge branch 'master' into eval-map-dot-to-list
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a4110d1
@mattdowle mattdowle merged commit 8bfd168 into master Feb 27, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 95.05%)
Details
codecov/project 95.06% (+<.01%) compared to f49ea2f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattdowle mattdowle deleted the eval-map-dot-to-list branch Feb 27, 2019
MichaelChirico pushed a commit that referenced this pull request Apr 3, 2019
@jangorecki Michael Chirico
eval on quoted expression of := will handle dot alias (#3425)
30fcf31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jangorecki @mattdowle
You can’t perform that action at this time.