Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbindlist check message for automatic names too #3484

Merged
merged 1 commit into from Mar 29, 2019
Merged

Conversation

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Mar 28, 2019

PR statistikat/tatoo#5 submitted to tatoo. The only revdep affected.
Plenty of time for tatoo to update on CRAN before 1.12.4 is released.

@mattdowle mattdowle added this to the 1.12.4 milestone Mar 28, 2019
@codecov
Copy link

@codecov codecov bot commented Mar 28, 2019

Codecov Report

Merging #3484 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3484      +/-   ##
==========================================
- Coverage   96.15%   96.15%   -0.01%     
==========================================
  Files          65       65              
  Lines       12229    12227       -2     
==========================================
- Hits        11759    11757       -2     
  Misses        470      470
Impacted Files Coverage Δ
src/rbindlist.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8603485...d607138. Read the comment docs.

@mattdowle mattdowle merged commit 712e022 into master Mar 29, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 96.15%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.84% compared to 8603485
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattdowle mattdowle deleted the rbindlist_check_V1 branch Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.