Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd c, seq, mean methods so ITime retains class #3630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
==========================================
+ Coverage 98.19% 98.19% +<.01%
==========================================
Files 66 66
Lines 12923 12924 +1
==========================================
+ Hits 12690 12691 +1
Misses 233 233
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
=========================================
+ Coverage 98.19% 98.2% +<.01%
=========================================
Files 66 66
Lines 12923 12980 +57
=========================================
+ Hits 12690 12747 +57
Misses 233 233
Continue to review full report at Codecov.
|
|
Ideally to raise warning about functions to be deprecated, then in next version remove. Also mention in NEWS. |
|
In this case, I don't think those functions work at all, so I'm not sure how anybody could have used them... a Note in NEWS maybe |
|
I understand but it is unwise just to drop exported functions without any warning. |
Closes #3628
Also deleted
split.IDateandcut.IDatemethods. They are untested with no examples, and I really don't know what the expected behavior is.splitreturns alistand really the important part of the method is how to handle the splitting factorf, not the first argument.split.defaultalready retains theIDateclass:And
cutreturns afactorso I don't know howas.IDateis supposed to operate on that.