Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setnames() should treat different Encoding as non-equal strings #3849

Merged
merged 3 commits into from Sep 15, 2019
Merged

Conversation

@shrektan
Copy link
Member

shrektan commented Sep 9, 2019

Closes #3845

@shrektan shrektan added this to the 1.12.4 milestone Sep 9, 2019
@shrektan shrektan requested a review from MichaelChirico Sep 9, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #3849 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3849   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          71       71           
  Lines       13443    13443           
=======================================
  Hits        13366    13366           
  Misses         77       77
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10dc94...3fd9894. Read the comment docs.

inst/tests/tests.Rraw Outdated Show resolved Hide resolved
@shrektan shrektan added the encoding label Sep 9, 2019
@shrektan shrektan mentioned this pull request Sep 13, 2019
25 of 25 tasks complete
@mattdowle mattdowle changed the title Closes #3845: setnames() should treat different Encoding as non-equal strings setnames() should treat different Encoding as non-equal strings Sep 14, 2019
mattdowle added 2 commits Sep 14, 2019
Copy link
Member

mattdowle left a comment

Great. Thanks for catching this before release!

@mattdowle mattdowle merged commit 3883689 into master Sep 15, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 99.42%)
Details
codecov/project 99.42% (+0%) compared to b10dc94
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattdowle mattdowle deleted the fix3845 branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.