fix NA filled by shift(nanotime, fill=NA) #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3942 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 72 72
Lines 13643 13642 -1
=========================================
- Hits 13562 13561 -1
Misses 81 81
Continue to review full report at Codecov.
|
|
LGTM. Could file an issue as well that we could close with this? Easier to find it there if anyone else notices the issue before next release |
|
Closes #3945, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3945
Currently
shift(nanotime(1:4))incorrectly fills anumericNArather than aninteger64NAinto the result vector. This is because we incorrectly check that the class is exactlyinteger64, rather than inherited from it, as we do in most other contexts. This PR fixes that, and adds test cases for shift called on nanotimes.