Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NA filled by shift(nanotime, fill=NA) #3942

Merged
merged 3 commits into from Oct 6, 2019
Merged

fix NA filled by shift(nanotime, fill=NA) #3942

merged 3 commits into from Oct 6, 2019

Conversation

mschubmehl
Copy link
Contributor

@mschubmehl mschubmehl commented Oct 5, 2019

Closes #3945

Currently shift(nanotime(1:4)) incorrectly fills a numeric NA rather than an integer64 NA into the result vector. This is because we incorrectly check that the class is exactly integer64, rather than inherited from it, as we do in most other contexts. This PR fixes that, and adds test cases for shift called on nanotimes.

@codecov
Copy link

@codecov codecov bot commented Oct 5, 2019

Codecov Report

Merging #3942 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3942      +/-   ##
=========================================
- Coverage    99.4%   99.4%   -0.01%     
=========================================
  Files          72      72              
  Lines       13643   13642       -1     
=========================================
- Hits        13562   13561       -1     
  Misses         81      81
Impacted Files Coverage Δ
src/shift.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a004873...e449d6b. Read the comment docs.

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Oct 6, 2019

LGTM. Could file an issue as well that we could close with this? Easier to find it there if anyone else notices the issue before next release

Copy link
Member

@jangorecki jangorecki left a comment

LGTM

@mschubmehl
Copy link
Contributor Author

@mschubmehl mschubmehl commented Oct 6, 2019

Closes #3945, and NEWS.md updated to reflect that. Thanks, all!

@mattdowle mattdowle merged commit 4b855a6 into master Oct 6, 2019
4 checks passed
@jangorecki jangorecki deleted the shift-nanotime branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants