Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix NA filled by shift(nanotime, fill=NA) #3942
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3942 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 72 72
Lines 13643 13642 -1
=========================================
- Hits 13562 13561 -1
Misses 81 81
Continue to review full report at Codecov.
|
|
LGTM. Could file an issue as well that we could close with this? Easier to find it there if anyone else notices the issue before next release |
|
LGTM |
|
Closes #3945, and |
4b855a6
into
master
Closes #3945
Currently
shift(nanotime(1:4))incorrectly fills anumericNArather than aninteger64NAinto the result vector. This is because we incorrectly check that the class is exactlyinteger64, rather than inherited from it, as we do in most other contexts. This PR fixes that, and adds test cases for shift called on nanotimes.