Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrospective license change permission #4140

Merged
merged 2 commits into from Feb 16, 2020
Merged

Retrospective license change permission #4140

merged 2 commits into from Feb 16, 2020

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Dec 27, 2019

Dear @dselivanov, @chenghlee, @cooldome, and @blasern,

You are receiving this because you have contributed code to the data.table project before Nov 2017 but were not consulted in the license change PR #2456. The reason you were missed is shown below. A recent discussion, thanks to @dselivanov, instigated a review: see the bottom of PR #1236. The result of this review is that your 4 names are the ones we need to retrospectively ask your permission for the license change, and also add your names to list of contributors in DESCRIPTION which is displayed on CRAN.

Who PR Why
@dselivanov #1236 Missing from GitHub contributors page due to invalid format email address
@cooldome #1434 Missing from GitHub contributors page due to invalid format email address
@blasern #1155 Missing from GitHub contributors page due to (TBC) invalid format email address
@chenghlee #1457 Makevars is a script in the package and should not have been excluded

Please read #2456. If you approve of the license change, please add a review approving this retrospective PR. You are approving both the license change and adding your names to DESCRIPTION. Please also add an approving review to #2456 if GitHub will let you (I don't know if GitHub will let you add approvals to merged PRs).

If you disagree with the license change please reply here, add a review which rejects this PR, or let me know on email and we can discuss further.

Many thanks, and I'm sorry you were not properly credited before.

Best, Matt

@mattdowle mattdowle added this to the 1.12.9 milestone Dec 27, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 27, 2019

Codecov Report

Merging #4140 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
+ Coverage   99.41%   99.61%   +0.19%     
==========================================
  Files          72       72              
  Lines       13909    13901       -8     
==========================================
+ Hits        13828    13847      +19     
+ Misses         81       54      -27     
Impacted Files Coverage Δ
R/xts.R 100.00% <0.00%> (ø) ⬆️
R/fcast.R 100.00% <0.00%> (ø) ⬆️
R/frank.R 100.00% <0.00%> (ø) ⬆️
R/utils.R 100.00% <0.00%> (ø) ⬆️
R/setops.R 100.00% <0.00%> (ø) ⬆️
src/fcast.c 100.00% <0.00%> (ø) ⬆️
src/frank.c 100.00% <0.00%> (ø) ⬆️
src/gsumm.c 100.00% <0.00%> (ø) ⬆️
src/assign.c 100.00% <0.00%> (ø) ⬆️
src/freadR.c 100.00% <0.00%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52b0d8...4866617. Read the comment docs.

@dselivanov
Copy link

@dselivanov dselivanov commented Dec 27, 2019

Thanks @mattdowle, I'm approving.

@mattdowle
Copy link
Member Author

@mattdowle mattdowle commented Dec 27, 2019

Thanks @dselivanov, and thanks for bringing it to our attention. Please click the Files Changed tab and then Review Changes button, and then approve that way please. Hoping for 4 ticks in the top right under reviewers.

@mattdowle
Copy link
Member Author

@mattdowle mattdowle commented Dec 30, 2019

@chenghlee many thanks, I saw your approval on the original PR 2456. Please could you add your approval to this PR as well. Please click the Files Changed tab and then Review Changes button, and then approve. Hoping for 4 ticks in the top right under reviewers.

@mattdowle
Copy link
Member Author

@mattdowle mattdowle commented Jan 14, 2020

Hi @cooldome, did you see this PR? Waiting for you to approve please before I can merge.

@cooldome
Copy link

@cooldome cooldome commented Feb 14, 2020

Approved

@mattdowle mattdowle merged commit 1dd65e6 into master Feb 16, 2020
4 checks passed
@mattdowle mattdowle deleted the license_retro branch Feb 16, 2020
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants