From 9ea05a51e8dd05596458169720394a7db0524254 Mon Sep 17 00:00:00 2001
From: Petr Stefan <ptr.stef@gmail.com>
Date: Thu, 26 Oct 2017 17:08:03 +0200
Subject: [PATCH 1/4] Evaluation detail props reorganization

---
 .../EvaluationDetail/EvaluationDetail.js      | 23 ++-----
 .../ReferenceSolutionEvaluationDetail.js      | 19 +++---
 .../EvaluationDetail/EvaluationDetail.js      | 68 +++++++------------
 .../SubmissionDetail/SubmissionDetail.js      | 31 ++++-----
 4 files changed, 55 insertions(+), 86 deletions(-)

diff --git a/src/components/ReferenceSolutions/EvaluationDetail/EvaluationDetail.js b/src/components/ReferenceSolutions/EvaluationDetail/EvaluationDetail.js
index a6d03e145..2d7cba726 100644
--- a/src/components/ReferenceSolutions/EvaluationDetail/EvaluationDetail.js
+++ b/src/components/ReferenceSolutions/EvaluationDetail/EvaluationDetail.js
@@ -12,7 +12,7 @@ import { Table } from 'react-bootstrap';
 import Box from '../../widgets/Box';
 import { MaybeSucceededIcon } from '../../icons';
 
-const EvaluationDetail = ({ evaluation, note = '' }) => (
+const EvaluationDetail = ({ evaluation, isCorrect }) =>
   <Box
     title={
       <FormattedMessage
@@ -40,18 +40,6 @@ const EvaluationDetail = ({ evaluation, note = '' }) => (
           </td>
         </tr>
 
-        <tr>
-          <th>
-            <FormattedMessage
-              id="app.evaluationDetail.isValid"
-              defaultMessage="Evaluation is valid:"
-            />
-          </th>
-          <td className="text-center">
-            <MaybeSucceededIcon success={evaluation.isValid} />
-          </td>
-        </tr>
-
         <tr>
           <th>
             <FormattedMessage
@@ -74,8 +62,8 @@ const EvaluationDetail = ({ evaluation, note = '' }) => (
           <td
             className={classnames({
               'text-center': true,
-              'text-danger': !evaluation.isCorrect,
-              'text-success': evaluation.isCorrect
+              'text-danger': !isCorrect,
+              'text-success': isCorrect
             })}
           >
             <b>
@@ -85,12 +73,11 @@ const EvaluationDetail = ({ evaluation, note = '' }) => (
         </tr>
       </tbody>
     </Table>
-  </Box>
-);
+  </Box>;
 
 EvaluationDetail.propTypes = {
   evaluation: PropTypes.object.isRequired,
-  note: PropTypes.string
+  isCorrect: PropTypes.bool.isRequired
 };
 
 export default EvaluationDetail;
diff --git a/src/components/ReferenceSolutions/ReferenceSolutionEvaluationDetail/ReferenceSolutionEvaluationDetail.js b/src/components/ReferenceSolutions/ReferenceSolutionEvaluationDetail/ReferenceSolutionEvaluationDetail.js
index 7827949e7..effa86b60 100644
--- a/src/components/ReferenceSolutions/ReferenceSolutionEvaluationDetail/ReferenceSolutionEvaluationDetail.js
+++ b/src/components/ReferenceSolutions/ReferenceSolutionEvaluationDetail/ReferenceSolutionEvaluationDetail.js
@@ -33,7 +33,7 @@ class ReferenceSolutionEvaluationDetail extends Component {
               exerciseId={exerciseId}
             />
             <Row>
-              {referenceSolution.solution.files.map(file => (
+              {referenceSolution.solution.files.map(file =>
                 <Col lg={6} md={12} key={file.id}>
                   <a
                     href="#"
@@ -45,19 +45,21 @@ class ReferenceSolutionEvaluationDetail extends Component {
                     <SourceCodeInfoBox {...file} />
                   </a>
                 </Col>
-              ))}
+              )}
             </Row>
-            {solutionEvaluation.evaluation && (
+            {solutionEvaluation.evaluation &&
               <CompilationLogs
                 initiationOutputs={
                   solutionEvaluation.evaluation.initiationOutputs
                 }
-              />
-            )}
+              />}
           </Col>
-          {solutionEvaluation.evaluation && (
+          {solutionEvaluation.evaluation &&
             <Col lg={6} sm={12}>
-              <EvaluationDetail evaluation={solutionEvaluation.evaluation} />
+              <EvaluationDetail
+                evaluation={solutionEvaluation.evaluation}
+                isCorrect={solutionEvaluation.isCorrect}
+              />
 
               <TestResults
                 evaluation={solutionEvaluation.evaluation}
@@ -71,8 +73,7 @@ class ReferenceSolutionEvaluationDetail extends Component {
                   </a>
                 </Col>
               </Row>
-            </Col>
-          )}
+            </Col>}
         </Row>
 
         <SourceCodeViewerContainer
diff --git a/src/components/Submissions/EvaluationDetail/EvaluationDetail.js b/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
index d99ebde9f..45c9234ad 100644
--- a/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
+++ b/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
@@ -17,10 +17,10 @@ import BonusPoints from '../../Assignments/SubmissionsTable/BonusPoints';
 const EvaluationDetail = ({
   assignment: { firstDeadline, allowSecondDeadline, secondDeadline },
   evaluation,
-  note = '',
+  isCorrect,
   submittedAt,
   maxPoints
-}) => (
+}) =>
   <Box
     title={
       <FormattedMessage
@@ -56,40 +56,25 @@ const EvaluationDetail = ({
             />
           </th>
           <td className="text-center">
-            {submittedAt < firstDeadline ? (
-              <Icon name="check" className="text-success" />
-            ) : (
-              <Icon name="times" className="text-danger" />
-            )}
+            {submittedAt < firstDeadline
+              ? <Icon name="check" className="text-success" />
+              : <Icon name="times" className="text-danger" />}
           </td>
         </tr>
 
         {submittedAt >= firstDeadline &&
-          allowSecondDeadline === true && (
-            <tr>
-              <th>
-                <FormattedMessage
-                  id="app.evaluationDetail.beforeSecondDeadline"
-                  defaultMessage="Was submitted before the second deadline:"
-                />
-              </th>
-              <td className="text-center">
-                <MaybeSucceededIcon success={submittedAt < secondDeadline} />
-              </td>
-            </tr>
-          )}
-
-        <tr>
-          <th>
-            <FormattedMessage
-              id="app.evaluationDetail.isValid"
-              defaultMessage="Evaluation is valid:"
-            />
-          </th>
-          <td className="text-center">
-            <MaybeSucceededIcon success={evaluation.isValid} />
-          </td>
-        </tr>
+          allowSecondDeadline === true &&
+          <tr>
+            <th>
+              <FormattedMessage
+                id="app.evaluationDetail.beforeSecondDeadline"
+                defaultMessage="Was submitted before the second deadline:"
+              />
+            </th>
+            <td className="text-center">
+              <MaybeSucceededIcon success={submittedAt < secondDeadline} />
+            </td>
+          </tr>}
 
         <tr>
           <th>
@@ -113,8 +98,8 @@ const EvaluationDetail = ({
           <td
             className={classnames({
               'text-center': true,
-              'text-danger': !evaluation.isCorrect,
-              'text-success': evaluation.isCorrect
+              'text-danger': !isCorrect,
+              'text-success': isCorrect
             })}
           >
             <b>
@@ -142,7 +127,7 @@ const EvaluationDetail = ({
             {evaluation.points}/{maxPoints}
           </td>
         </tr>
-        {evaluation.bonusPoints !== 0 && (
+        {evaluation.bonusPoints !== 0 &&
           <tr>
             <th>
               <FormattedMessage
@@ -153,9 +138,8 @@ const EvaluationDetail = ({
             <td className="text-center">
               <BonusPoints bonus={evaluation.bonusPoints} />
             </td>
-          </tr>
-        )}
-        {evaluation.bonusPoints !== 0 && (
+          </tr>}
+        {evaluation.bonusPoints !== 0 &&
           <tr>
             <th>
               <FormattedMessage
@@ -178,12 +162,10 @@ const EvaluationDetail = ({
                 {evaluation.points + evaluation.bonusPoints}/{maxPoints}
               </b>
             </td>
-          </tr>
-        )}
+          </tr>}
       </tbody>
     </Table>
-  </Box>
-);
+  </Box>;
 
 EvaluationDetail.propTypes = {
   assignment: PropTypes.shape({
@@ -191,7 +173,7 @@ EvaluationDetail.propTypes = {
     allowSecondDeadline: PropTypes.bool.isRequired,
     secondDeadline: PropTypes.number
   }).isRequired,
-  note: PropTypes.string,
+  isCorrect: PropTypes.bool.isRequired,
   submittedAt: PropTypes.number.isRequired,
   evaluation: PropTypes.object,
   maxPoints: PropTypes.number.isRequired
diff --git a/src/components/Submissions/SubmissionDetail/SubmissionDetail.js b/src/components/Submissions/SubmissionDetail/SubmissionDetail.js
index c6335b5e5..ea01ac235 100644
--- a/src/components/Submissions/SubmissionDetail/SubmissionDetail.js
+++ b/src/components/Submissions/SubmissionDetail/SubmissionDetail.js
@@ -32,7 +32,8 @@ class SubmissionDetail extends Component {
         evaluation,
         accepted,
         originalSubmissionId,
-        runtimeEnvironmentId
+        runtimeEnvironmentId,
+        isCorrect
       },
       assignment,
       isSupervisor
@@ -54,7 +55,7 @@ class SubmissionDetail extends Component {
               assignmentId={assignment.id}
             />
             <Row>
-              {files.map(file => (
+              {files.map(file =>
                 <Col lg={6} md={12} key={file.id}>
                   <a
                     href="#"
@@ -66,46 +67,43 @@ class SubmissionDetail extends Component {
                     <SourceCodeInfoBox {...file} />
                   </a>
                 </Col>
-              ))}
+              )}
             </Row>
-            {evaluation && (
+            {evaluation &&
               <CompilationLogs
                 initiationOutputs={evaluation.initiationOutputs}
-              />
-            )}
+              />}
             <CommentThreadContainer threadId={id} />
           </Col>
 
-          {evaluation && (
+          {evaluation &&
             <Col md={6} sm={12}>
               <EvaluationDetail
                 assignment={assignment}
                 evaluation={evaluation}
                 submittedAt={submittedAt}
                 maxPoints={maxPoints}
+                isCorrect={isCorrect}
               />
 
-              {isSupervisor && (
+              {isSupervisor &&
                 <BonusPointsContainer
                   submissionId={id}
                   evaluation={evaluation}
-                />
-              )}
+                />}
 
               <TestResults
                 evaluation={evaluation}
                 runtimeEnvironmentId={runtimeEnvironmentId}
               />
 
-              {isSupervisor && (
+              {isSupervisor &&
                 <Row>
                   <Col lg={6} md={12}>
                     <DownloadResultArchiveContainer submissionId={id} />
                   </Col>
-                </Row>
-              )}
-            </Col>
-          )}
+                </Row>}
+            </Col>}
         </Row>
 
         <SourceCodeViewerContainer
@@ -130,7 +128,8 @@ SubmissionDetail.propTypes = {
     maxPoints: PropTypes.number.isRequired,
     files: PropTypes.array,
     originalSubmissionId: PropTypes.string,
-    runtimeEnvironmentId: PropTypes.string
+    runtimeEnvironmentId: PropTypes.string,
+    isCorrect: PropTypes.bool
   }).isRequired,
   assignment: PropTypes.object.isRequired,
   isSupervisor: PropTypes.bool

From 109a1c30115c6130ab3705ce0fcce0df67c365a8 Mon Sep 17 00:00:00 2001
From: Petr Stefan <ptr.stef@gmail.com>
Date: Thu, 26 Oct 2017 17:48:44 +0200
Subject: [PATCH 2/4] Display points threshold on assignment page

---
 .../AssignmentDetails/AssignmentDetails.js    | 20 +++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/components/Assignments/Assignment/AssignmentDetails/AssignmentDetails.js b/src/components/Assignments/Assignment/AssignmentDetails/AssignmentDetails.js
index bcd0e3b85..73ede757a 100644
--- a/src/components/Assignments/Assignment/AssignmentDetails/AssignmentDetails.js
+++ b/src/components/Assignments/Assignment/AssignmentDetails/AssignmentDetails.js
@@ -26,7 +26,8 @@ const AssignmentDetails = ({
   isAfterSecondDeadline,
   isBonus,
   runtimeEnvironments,
-  canSubmit
+  canSubmit,
+  pointsPercentualThreshold
 }) =>
   <Box
     title={
@@ -154,6 +155,20 @@ const AssignmentDetails = ({
               <SuccessIcon />
             </td>
           </tr>}
+        <tr>
+          <td className="text-center">
+            <Icon name="percent" />
+          </td>
+          <td>
+            <FormattedMessage
+              id="app.assignment.pointsPercentualThreshold"
+              defaultMessage="Points percentual threshold:"
+            />
+          </td>
+          <td>
+            {pointsPercentualThreshold * 100} %
+          </td>
+        </tr>
         <tr>
           <td className="text-center">
             <Icon name="code" />
@@ -188,7 +203,8 @@ AssignmentDetails.propTypes = {
   isAfterSecondDeadline: PropTypes.bool.isRequired,
   isBonus: PropTypes.bool,
   runtimeEnvironments: PropTypes.array,
-  canSubmit: ImmutablePropTypes.map
+  canSubmit: ImmutablePropTypes.map,
+  pointsPercentualThreshold: PropTypes.number
 };
 
 export default AssignmentDetails;

From ddcd3a5ff39c8f9286c78b2bea8ca8268644f070 Mon Sep 17 00:00:00 2001
From: Martin Polanka <PolankaMartin@gmail.com>
Date: Fri, 27 Oct 2017 08:51:54 +0200
Subject: [PATCH 3/4] isCorrect fixes

---
 .../Submissions/EvaluationDetail/EvaluationDetail.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/components/Submissions/EvaluationDetail/EvaluationDetail.js b/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
index 45c9234ad..cff6fb46c 100644
--- a/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
+++ b/src/components/Submissions/EvaluationDetail/EvaluationDetail.js
@@ -117,10 +117,8 @@ const EvaluationDetail = ({
           <td
             className={classnames({
               'text-center': true,
-              'text-danger':
-                !evaluation.isCorrect && evaluation.bonusPoints === 0,
-              'text-success':
-                evaluation.isCorrect && evaluation.bonusPoints === 0,
+              'text-danger': !isCorrect && evaluation.bonusPoints === 0,
+              'text-success': isCorrect && evaluation.bonusPoints === 0,
               'text-bold': evaluation.bonusPoints === 0
             })}
           >
@@ -151,11 +149,9 @@ const EvaluationDetail = ({
               className={classnames({
                 'text-center': true,
                 'text-danger':
-                  !evaluation.isCorrect ||
-                  evaluation.points + evaluation.bonusPoints <= 0,
+                  !isCorrect || evaluation.points + evaluation.bonusPoints <= 0,
                 'text-success':
-                  evaluation.isCorrect &&
-                  evaluation.points + evaluation.bonusPoints > 0
+                  isCorrect && evaluation.points + evaluation.bonusPoints > 0
               })}
             >
               <b>

From 27f99e0366530d72cd6ffeedb1f22351cdd26c53 Mon Sep 17 00:00:00 2001
From: Martin Polanka <PolankaMartin@gmail.com>
Date: Fri, 27 Oct 2017 09:04:35 +0200
Subject: [PATCH 4/4] Another isCorrect correction

---
 .../EvaluationTable/EvaluationTable.js        | 33 ++++++++-----------
 1 file changed, 14 insertions(+), 19 deletions(-)

diff --git a/src/components/ReferenceSolutions/EvaluationTable/EvaluationTable.js b/src/components/ReferenceSolutions/EvaluationTable/EvaluationTable.js
index 646b6dccf..f0f58e6c5 100644
--- a/src/components/ReferenceSolutions/EvaluationTable/EvaluationTable.js
+++ b/src/components/ReferenceSolutions/EvaluationTable/EvaluationTable.js
@@ -18,7 +18,7 @@ const EvaluationTable = ({
   referenceSolutionId,
   exerciseId,
   links: { REFERENCE_SOLUTION_EVALUATION_URI_FACTORY }
-}) => (
+}) =>
   <Table>
     <thead>
       <tr>
@@ -46,7 +46,7 @@ const EvaluationTable = ({
           }
           return b.evaluation.evaluatedAt - a.evaluation.evaluatedAt;
         })
-        .map(e => (
+        .map(e =>
           <tr key={e.id}>
             <td>
               <AssignmentStatusIcon
@@ -55,26 +55,24 @@ const EvaluationTable = ({
                 accepted={false}
               />
             </td>
-            {e.evaluation && (
+            {e.evaluation &&
               <td>
                 <FormattedDate value={e.evaluation.evaluatedAt * 1000} />
                 &nbsp;
                 <FormattedTime value={e.evaluation.evaluatedAt * 1000} />
-              </td>
-            )}
-            {e.evaluation && (
+              </td>}
+            {e.evaluation &&
               <td
                 className={classnames({
-                  'text-danger': !e.evaluation.isCorrect,
-                  'text-success': e.evaluation.isCorrect
+                  'text-danger': !e.isCorrect,
+                  'text-success': e.isCorrect
                 })}
               >
                 <b>
                   <FormattedNumber style="percent" value={e.evaluation.score} />
                 </b>
-              </td>
-            )}
-            {!e.evaluation && (
+              </td>}
+            {!e.evaluation &&
               <td colSpan="2">
                 <i>
                   <FormattedMessage
@@ -82,8 +80,7 @@ const EvaluationTable = ({
                     defaultMessage="Evaluation not available"
                   />
                 </i>
-              </td>
-            )}
+              </td>}
             <td className="text-right">
               <Link
                 to={REFERENCE_SOLUTION_EVALUATION_URI_FACTORY(
@@ -100,9 +97,9 @@ const EvaluationTable = ({
               </Link>
             </td>
           </tr>
-        ))}
+        )}
 
-      {evaluations.length === 0 && (
+      {evaluations.length === 0 &&
         <tr>
           <td className="text-center" colSpan={3}>
             <FormattedMessage
@@ -110,11 +107,9 @@ const EvaluationTable = ({
               defaultMessage="There are no evaluations in this list."
             />
           </td>
-        </tr>
-      )}
+        </tr>}
     </tbody>
-  </Table>
-);
+  </Table>;
 
 EvaluationTable.propTypes = {
   evaluations: PropTypes.array.isRequired,