Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anti-patterns in extractor.py module #644

Closed
lil-skelly opened this issue May 31, 2023 · 0 comments
Closed

Anti-patterns in extractor.py module #644

lil-skelly opened this issue May 31, 2023 · 0 comments

Comments

@lil-skelly
Copy link

There are multiple logic errors/anti-patterns throughout the extractor.py

  • Unused exception handles
  • Using is for literal comparison
  • E712 occurrences.
    I already created a pull request that solves all of these anti-patterns.
    Fixed extractor.py module #633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devttys0 @lil-skelly