Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
SignUpModal can't be extended by other extensions with user-management active #20
This extension overrides the prototype methods of SignUpModal, making it impossible to extend by any other extension. In particular this breaks compatibility with Flagrow Terms.
The faulty code is around here in the
If an extension like Flagrow Terms is loaded before User Management and extending the
I suggest you use similar hacking to what I did in Terms https://github.com/flagrow/terms/blob/master/js/forum/src/addFieldsToRegister.js so you don't break extensibility for other extensions.
Of course once merged there will be a prettier way to do it in beta8 as already discussed on the forum flarum/core#1420
I can submit a pull request if you want.
We're planning to remove the registration related features that's currently in this extension. A Strikes extension will handle the strikes portion and "Reggy" will handle the registration modal related plans we have once your fix as well as Flarum Beta 8 become available.
I'll update the User Management compser.json and add the following line until we can get this issue resolved:
or should I be using