Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Review Request : R. Larisch #57
I request a review for the following replication:
Title: Connectivity reflects coding: a model of voltage-based STDP with homeostasis
Author(s): Larisch, R.
Sorry for the delay. Here's my review of the updates, based on commit c869eee:
All of my main concerns have been addressed by the updates. Concerning replication, the control experiments (Figure 4 c and d) are now included. It is now much clearer which parts of the implementation were taken from the published Matlab code and how and why certain parameters were changed. Figure 5 and 6 are still not reproduced, but as discussed before I do support publication as a partial replication.
The code is now reproducible thanks to the use of a random seed in the experiment on receptive field formation.
Concerning clarity, I think the paper reads more fluently now. The supplement helps keep an overview over the parameters.
Some minor issues remain, which should be easy to fix:
I am happy with the changes, in particular running the code locally now produces identical figures to those in the manuscript.
A couple of minor points:
As I mentioned in the original review, I don't think this should be described as a "reference implementation" because of the parameter changes that were needed, but I support publishing it as a partial replication.
1 similar comment
Hi @rLarisch, because you use the old Rescience template you have to update the metadata on your side. I attach the corresponding metadata.yaml file that you have to use (I have filled out all the necessary information).
Hi @rLarisch, your article is now online http://rescience.github.io/bibliography/Larisch_2019.html