From 87a622454e05e830e3df176306b1229883fb4793 Mon Sep 17 00:00:00 2001 From: Arfon Smith Date: Wed, 27 Sep 2023 10:30:07 +0100 Subject: [PATCH] Adding editor status to JSON response --- app/models/editor.rb | 8 ++++++++ app/views/papers/show.json.jbuilder | 1 + spec/controllers/papers_controller_spec.rb | 1 + 3 files changed, 10 insertions(+) diff --git a/app/models/editor.rb b/app/models/editor.rb index be745acb..52f78b77 100644 --- a/app/models/editor.rb +++ b/app/models/editor.rb @@ -36,6 +36,14 @@ def category_list categories.join(", ") end + def status + if retired? + "Retired" + else + "Active" + end + end + def three_month_average paper_count = self.papers.visible.since(3.months.ago).count return sprintf("%.1f", paper_count / 3.0) diff --git a/app/views/papers/show.json.jbuilder b/app/views/papers/show.json.jbuilder index fcfe218d..90254b7a 100644 --- a/app/views/papers/show.json.jbuilder +++ b/app/views/papers/show.json.jbuilder @@ -12,6 +12,7 @@ if @paper.published? json.authors @paper.metadata_authors json.submitting_author @paper&.submitting_author&.pretty_github_username json.editor @paper.metadata_editor + json.editor_status @paper&.editor&.status if @paper.editor json.editor_name @paper.editor.full_name json.editor_url @paper.editor.url if @paper.editor.url diff --git a/spec/controllers/papers_controller_spec.rb b/spec/controllers/papers_controller_spec.rb index e6db8397..aa38498c 100644 --- a/spec/controllers/papers_controller_spec.rb +++ b/spec/controllers/papers_controller_spec.rb @@ -404,6 +404,7 @@ expect(parsed_response["state"]).to eq("accepted") expect(parsed_response["software_repository"]).to eq("http://github.com/arfon/fidgit") expect(parsed_response["editor"]).to eq("@arfon") + expect(parsed_response["editor_status"]).to eq("Active") expect(parsed_response["submitting_author"]).to eq("@foobar") expect(parsed_response["editor_name"]).to eq("Person McEditor") expect(parsed_response["editor_orcid"]).to eq("0000-0000-0000-1234")