Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(youtube): group integrations settings #2676

Closed
3 tasks done
TrianguloY opened this issue Jan 30, 2024 · 1 comment
Closed
3 tasks done

feat(youtube): group integrations settings #2676

TrianguloY opened this issue Jan 30, 2024 · 1 comment
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@TrianguloY
Copy link

Feature description

YouTube has 3 integrations: SponsorBlock, ReturnYoutubeDislike and AlternativeThumbnails/Dearrow.

The first two have a dedicated entry on the YouTube settings (Below Revanced and GmsCore) but the third one is present in Revanced>layout> almost at the bottom.

Settings:
- ...
- Revanced
  - ...
  - Layout
    - ...
    - Alternative Thumbnails
    - ...
  - ...
- GmsCore
- ReturnYouTubeDislike
- SponsorBlock

Sugestion

Create an integration entry directly on the settings, and add all three there.

Settings:
- ...
- Revanced
- Integrations
  - ReturnYouTubeDislike
  - SponsorBlock
  - Alternative Thumbnails
- GmsCore

Motivation

Integrations may be one of the main reasons revanced is used (other than filtering ads) and maybe more may be added in the future.
The first two had dedicated settings, but the third one does not, which is inconsistent.

By adding a dedicated entry for all integrations, users can easily find them and know which ones are available. The Revanced entry will be kept for standard YouTube modifications.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@TrianguloY TrianguloY added the Feature request Requesting a new feature that's not implemented yet label Jan 30, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Most end users don't know or care what integrations means.

And nearly all YouTube patches use integrations as well.

There is already talk of reorganize the settings here #2629

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.186.0-dev.3 [skip ci]
1c85c4b 
# [2.186.0-dev.3](ReVanced/revanced-patches@v2.186.0-dev.2...v2.186.0-dev.3) (2023-07-20)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@6a3785a))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.186.0 [skip ci]
245c6b5 
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@6a3785a))
* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@fbe55bf))
* **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@d81e124))
* **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@96e3f68))

### Features

* **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@e91ecb9))
* **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@232b6f3))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.186.0-dev.3 [skip ci]
dafe24f 
# [2.186.0-dev.3](ReVanced/revanced-patches@v2.186.0-dev.2...v2.186.0-dev.3) (2023-07-20)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@b34e45b))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.186.0 [skip ci]
f38982d 
# [2.186.0](ReVanced/revanced-patches@v2.185.0...v2.186.0) (2023-07-21)

### Bug Fixes

* **Tiktok - Settings:** get instruction registers dynamically ([ReVanced#2676](ReVanced/revanced-patches#2676)) ([b34e45b](ReVanced/revanced-patches@b34e45b))
* **YouTube - Spoof app version:** update target app version description ([ReVanced#2666](ReVanced/revanced-patches#2666)) ([307442e](ReVanced/revanced-patches@307442e))
* **YouTube - Theme:** allow setting no background color ([8a4e77a](ReVanced/revanced-patches@8a4e77a))
* **YouTube - Theme:** apply custom seekbar color to shorts ([ReVanced#2670](ReVanced/revanced-patches#2670)) ([1f6fe3d](ReVanced/revanced-patches@1f6fe3d))

### Features

* **Twitter:** remove `Hide view stats` patch ([f0d3800](ReVanced/revanced-patches@f0d3800))
* **Youtube - Theme:** add a switch to enable/disable custom seekbar color ([ReVanced#2663](ReVanced/revanced-patches#2663)) ([5c39985](ReVanced/revanced-patches@5c39985))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrianguloY @LisoUseInAIKyrios